Skip to content

fix: handle ask user name collision policy #15920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: handle ask user name collision policy #15920

wants to merge 4 commits into from
+296 −272

Conversation

@alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Nov 6, 2025 •
edited
Loading

  • Tests written, or not not needed

Currently, FileUploadWorker handles the NameCollisionPolicy.ASK_USER this PR brings the same functionality for the AutoUpload.

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 6, 2025
View reviewed changes
app/src/main/java/com/nextcloud/client/jobs/notification/WorkerNotificationManager.kt
}

fun showNotification(notification: Notification) {
notificationManager.notify(id, notification)

Check failure

Code scanning / CodeQL

Use of implicit PendingIntents High

An implicit Intent is created
Loading
and sent to an unspecified third party through a PendingIntent.
An implicit Intent is created
Loading
and sent to an unspecified third party through a PendingIntent.
An implicit Intent is created
Loading
and sent to an unspecified third party through a PendingIntent.

Copilot Autofix

AI 31 minutes ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

@alperozturk96 alperozturk96 force-pushed the fix/handle-ask-user-name-collision-policy branch from 157c61f to 48d5e3f Compare November 13, 2025 09:20
@github-actions
Copy link

github-actions bot commented Nov 13, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15920.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@alperozturk96 alperozturk96 force-pushed the fix/handle-ask-user-name-collision-policy branch from 48d5e3f to b7ec9c7 Compare November 13, 2025 14:16
@alperozturk96
fix error handling
009c3c2 
Signed-off-by: alperozturk <[email protected]>
@github-actions
Copy link

github-actions bot commented Nov 13, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15920.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link

github-actions bot commented Nov 13, 2025

test-Unit test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/15920-Unit-test-16-35

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 13, 2025
View reviewed changes
app/src/main/java/com/nextcloud/client/jobs/notification/WorkerNotificationManager.kt
}

fun showNotification(notification: Notification) {
notificationManager.notify(id, notification)

Check failure

Code scanning / CodeQL

Use of implicit PendingIntents High

An implicit Intent is created
Loading
and sent to an unspecified third party through a PendingIntent.
An implicit Intent is created
Loading
and sent to an unspecified third party through a PendingIntent.
An implicit Intent is created
Loading
and sent to an unspecified third party through a PendingIntent.

Copilot Autofix

AI 31 minutes ago

Copilot could not generate an autofix suggestion

Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

2. developing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alperozturk96