Reflect public shares in isPublic flag and fix permission check
#55147
+123
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salmart-dev
force-pushed
the
fixPublicShares
branch
from
4b2d141 to
40e4ac0
Compare
36 tasks
salmart-dev
force-pushed
the
fixPublicShares
branch
2 times, most recently
from
9535adf to
ce8e8bd
Compare
salmart-dev
changed the title
isPublic flag and fix permission check
salmart-dev
requested review from
ArtificialOwl,
CarlSchwan and
leftybournes
and removed request for
a team
CarlSchwan
reviewed
Oct 16, 2025
salmart-dev
force-pushed
the
fixPublicShares
branch
from
3eab8d0 to
305ce63
Compare
salmart-dev
force-pushed
the
fixPublicShares
branch
from
ffc64f1 to
31143ea
Compare
CarlSchwan
approved these changes
Nov 24, 2025
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
LGTM, but can you rebase and test everything again, as I fixed some things with chunked upload recently? I just want to avoid a regression with these changes.
Signed-off-by: Salvatore Martire <[email protected]>
The isPublicShare was set to false in one instance where it should have been true. Flipping the value to true, would break the functionality for PROPFIND /public.php/webdav/ which returns properties of files in a share identified by the username being the share token. Signed-off-by: Salvatore Martire <[email protected]>
instanceof cannot be used to check the instance of a storage, doing so breaks the check in certain cases. In this case, enabling the `files_accesscontrol` app breaks the check. Signed-off-by: Salvatore Martire <[email protected]>
Signed-off-by: Salvatore Martire <[email protected]>
salmart-dev
force-pushed
the
fixPublicShares
branch
from
31143ea to
631318f
Compare
Contributor
Author
Tested:
So it seems all is still good 👍 |
provokateurin
approved these changes
Dec 1, 2025
salmart-dev
added
4. to release
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
/backport to stable31 |
This was referenced Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/public.php/webdavin feat: add oc-ownerid and oc-permissions headers on PUT DAV requests #54542Summary
Fixes some issues introduced in the PR above, namely:
isPublicSharewasfalsein an instance where it should have been set to true. Flipping it to reflect the publicity of the share would break a compatibility functionality (read more below)files_accesscontrolapp, instead of the functioninstanceOfStoragewhich checks if the instance itself or any wrapped storages (or wrappers) are instance of the passed class.Compatibility Issue
For compatibility reasons the API call
PROPFIND http://nextcloud.local/public.php/webdavshould return the properties of the files in a public share. The share is identified through its ID, sent through the authorization header as username. In the master code, flipping the boolisPublicShareto true would break this functionality by changing the way the DAV tree is set up.Checklist