-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Improve wording for login throttle warning #56763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: himehatsumi <[email protected]>
szaimen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| } | ||
| if (this.throttleDelay > 5000) { | ||
| return t('core', 'We have detected multiple invalid login attempts from your IP. Therefore your next login is throttled up to 30 seconds.') | ||
| return t('core', 'Too many incorrent login attempts. Please try again in 30 seconds.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
incorrent -> incorrect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find the original message more informative. It lets the user know that the slowdown is caused by failed attempts from their own IP address.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Someone in the issue said that they would also be okay with just "Try again in 30 seconds." I thought this version would add a bit more clarity but improve upon the current message even if it may be more informative.
Signed-off-by: himehatsumI <[email protected]>
|
should be properly fixed now i think? |
|
cc @nextcloud/designers for an input |
nimishavijay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much more clear now :) We can keep the "Too many incorrect login attempts" as it helps specify what is the issue 👍
jancborchardt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, simpler and less technical/scary wording and still keeps the essence.
Summary
Simplify the login throttling warning message shown after multiple failed login attempts.
The original message was long and potentially confusing. This update replaces it with a concise, user-friendly version.
TODO
LoginForm.vueChecklist
3. to review, feature component)32.xforstable32)