Skip to content

Conversation

@himehatsumi
Copy link

@himehatsumi himehatsumi commented Dec 1, 2025

Summary

Simplify the login throttling warning message shown after multiple failed login attempts.
The original message was long and potentially confusing. This update replaces it with a concise, user-friendly version.

TODO

  • Update the message in LoginForm.vue

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Screenshots before/after for front-end changes
  • Documentation (manuals or wiki) has been updated or is not required
  • Backports requested where applicable (ex: critical bugfixes)
  • Labels added (ex: bug/enhancement, 3. to review, feature component)
  • Milestone added for target branch/version (e.g., 32.x for stable32)

@himehatsumi himehatsumi requested a review from a team as a code owner December 1, 2025 10:09
@himehatsumi himehatsumi requested review from artonge, skjnldsv and szaimen and removed request for a team December 1, 2025 10:09
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szaimen szaimen requested a review from rakekniven December 1, 2025 10:17
@szaimen szaimen added this to the Nextcloud 33 milestone Dec 1, 2025
@szaimen szaimen added 3. to review Waiting for reviews feature: language/translations (l10n/i18n) Localization and translation matters labels Dec 1, 2025
}
if (this.throttleDelay > 5000) {
return t('core', 'We have detected multiple invalid login attempts from your IP. Therefore your next login is throttled up to 30 seconds.')
return t('core', 'Too many incorrent login attempts. Please try again in 30 seconds.')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

incorrent -> incorrect?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the original message more informative. It lets the user know that the slowdown is caused by failed attempts from their own IP address.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Someone in the issue said that they would also be okay with just "Try again in 30 seconds." I thought this version would add a bit more clarity but improve upon the current message even if it may be more informative.

Signed-off-by: himehatsumI <[email protected]>
@himehatsumi
Copy link
Author

should be properly fixed now i think?

@artonge
Copy link
Contributor

artonge commented Dec 2, 2025

cc @nextcloud/designers for an input

Copy link
Member

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much more clear now :) We can keep the "Too many incorrect login attempts" as it helps specify what is the issue 👍

Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, simpler and less technical/scary wording and still keeps the essence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews feature: language/translations (l10n/i18n) Localization and translation matters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better wording for login warning

8 participants