fix(template): add import map for JS module entry points #56941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
Altahrim,
CarlSchwan,
ShGKme,
artonge,
come-nc,
icewind1991 and
leftybournes
and removed request for
a team,
Altahrim and
icewind1991
susnux
force-pushed
the
fix/importmaps
branch
from
2d0cd15 to
f507b79
Compare
susnux
added a commit
to nextcloud/end_to_end_encryption
that referenced
this pull request
Dec 9, 2025
Vite will try to minimize the number of chunks to increase performance, but this will inline chunks in the entry point and thus adding exports that can be imported by other modules causing the entry point to be re-evaluated. So we need to disabled this until fixed in server: - ref: nextcloud/server#56941 Signed-off-by: Ferdinand Thiessen <[email protected]>
Currently apps are broken if they have exports in the JS entry point,
because they then will import from the entry point but because they do
not know about the Nextcloud cache buster they will import without cache
buster.
This results in two problem:
1. The module might be outdated (old cached)
2. The module is duplicated, so the module will be loaded twice and will
have two different - out of sync - states. This also means it will
re-run sideeffects of the entry point.
To fix this we generate an import map which basically maps the plain
entry point script to the script with cache buster added.
(Some background: Bundler will try to minimize chunks (reduce page
loading time) so they can inline modules into entry points and thus
extend the entry point exports and then this issue would be caused).
For example:
```js
// entry.mjs
console.error('called')
async function onClick() {
await import('./chunk.mjs')
}
export const name = 'foo'
// chunk.mjs
import { name } from './entry.mjs'
console.error(name)
```
When calling `onClick` without this fix the output will be:
> called
> called
> foo
With this fix:
> called
> foo
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/importmaps
branch
from
f507b79 to
94ec13f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently apps are broken if they have exports in the JS entry point, because they then will import from the entry point but because they do not know about the Nextcloud cache buster they will import without cache buster.
This results in two problem:
To fix this we generate an import map which basically maps the plain entry point script to the script with cache buster added.
Why this can happen?
If we want to reduce chunks the bundler can include exports from submodules into entry points and thus reduce the number of files. This is more performant on the web so this is a valid reason.
For example:
When calling
onClickwithout this fix the output will be:With this fix:
Checklist
3. to review, feature component)stable32)