Skip to content

refactor(QueryBuilder): Port away from deprecated execute method #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2025
Merged

refactor(QueryBuilder): Port away from deprecated execute method #885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/Migration/RepairProviderRegistrations.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ public function run(IOutput $output): void {
$deleteQb->expr()->eq('uid', $deleteQb->createParameter('uid')),
);

$result = $selectQb->execute();
$result = $selectQb->executeQuery();
while ($row = $result->fetch()) {
try {
$updateQb->setParameter('uid', $row['uid']);
Expand All @@ -62,7 +62,7 @@ public function run(IOutput $output): void {
if ($e->getReason() === Exception::REASON_UNIQUE_CONSTRAINT_VIOLATION) {
// The provider was registered twice for the user. We can safely drop the old one.
$deleteQb->setParameter('uid', $row['uid']);
$deleteQb->execute();
$deleteQb->executeStatement();
} else {
$output->warning(sprintf(
'%s Could not migrate %s:%s',
Expand Down
4 changes: 2 additions & 2 deletions lib/Migration/Version000202Date20200320192700.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,11 @@ public function preSchemaChange(IOutput $output, Closure $schemaClosure, array $

$this->connection->beginTransaction();
try {
$result = $select->execute();
$result = $select->executeQuery();
while ($row = $result->fetch()) {
$update->setParameter('aaguid', $this->getBytes($output, $row));
$update->setParameter('id', $row['id']);
$update->execute();
$update->executeStatement();
}
$result->closeCursor();
$this->connection->commit();
Expand Down
4 changes: 2 additions & 2 deletions lib/Migration/Version000203Date20200322200200.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,11 +74,11 @@ public function postSchemaChange(IOutput $output, Closure $schemaClosure, array

$this->connection->beginTransaction();
try {
$result = $select->execute();
$result = $select->executeQuery();
while ($row = $result->fetch()) {
$update->setParameter('aaguid_transform', $this->getUuidString($output, $row));
$update->setParameter('id', $row['id']);
$update->execute();
$update->executeStatement();
}
$result->closeCursor();
$this->connection->commit();
Expand Down
4 changes: 2 additions & 2 deletions lib/Migration/Version000203Date20200322201700.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,11 +72,11 @@ public function postSchemaChange(IOutput $output, Closure $schemaClosure, array

$this->connection->beginTransaction();
try {
$result = $select->execute();
$result = $select->executeQuery();
while ($row = $result->fetch()) {
$update->setParameter('aaguid', Uuid::fromString($row['aaguid_transform'])->toRfc4122());
$update->setParameter('id', $row['id']);
$update->execute();
$update->executeStatement();
}
$result->closeCursor();
$this->connection->commit();
Expand Down
4 changes: 2 additions & 2 deletions lib/Migration/Version000400Date20220524123120.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ public function postSchemaChange(IOutput $output, \Closure $schemaClosure, array
$selectQb->select('*')
->from('twofactor_webauthn_registrations');

$result = $selectQb->execute();
$result = $selectQb->executeQuery();
while ($row = $result->fetch()) {
$insertQb
->setParameter('name', $row['name'])
Expand All @@ -143,7 +143,7 @@ public function postSchemaChange(IOutput $output, \Closure $schemaClosure, array
->setParameter('user_handle', $row['user_handle'])
->setParameter('counter', (int)$row['counter'], IQueryBuilder::PARAM_INT)
->setParameter('active', (bool)$row['active'], IQueryBuilder::PARAM_BOOL);
$insertQb->execute();
$insertQb->executeStatement();
}
$result->closeCursor();
}
Expand Down