Skip to content

static-site[list-resources]: Fix crash in modal_draw() when bottoming out during radius calculations #1253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tsibley wants to merge 1 commit into
base: master
Choose a base branch
from
Open

static-site[list-resources]: Fix crash in modal_draw() when bottoming out during radius calculations #1253

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions static-site/components/list-resources/modal_draw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,29 +92,25 @@ export default function modal_draw(ref, resource, lightGrey) {
heights.marginBelowAxis;
let radius = 12;
const padding = 1;
let nextRadius = radius;
let iterCount = 0;
let beeswarmData;
let beeswarmHeight = 0;
let spareHeight = availBeeswarmHeight - beeswarmHeight - radius;
const maxIter = 5;
const radiusJump = 2;
while (iterCount++ < maxIter && spareHeight > 50) {
const nextBeeswarmData = dodge(flatData, {
radius: nextRadius * 2 + padding,
beeswarmData = dodge(flatData, {
radius: radius * 2 + padding,
x: (d) => x(d["date"]),
});
const nextBeeswarmHeight = d3.max(nextBeeswarmData.map((d) => d.y));
beeswarmHeight = d3.max(beeswarmData.map((d) => d.y));
const nextSpareHeight =
availBeeswarmHeight - nextBeeswarmHeight - nextRadius;
availBeeswarmHeight - beeswarmHeight - radius;
if (nextSpareHeight <= spareHeight && nextSpareHeight > 0) {
beeswarmData = nextBeeswarmData;
beeswarmHeight = nextBeeswarmHeight;
spareHeight = nextSpareHeight;
radius = nextRadius;
nextRadius += radiusJump;
radius += radiusJump;
} else {
nextRadius -= radiusJump;
radius -= radiusJump;
Comment on lines +102 to +113
Copy link
Member

@victorlin victorlin Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the bug, but the radius seems off:

Image

}
}

Expand Down