Use dynamic routes everywhere #1281
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextstrain-bot
had a problem deploying
to
nextstrain-s-victorlin--6wwa7b
3 tasks
joverlee521
reviewed
Dec 5, 2025
Comment on lines
+11
to
+12
| // NOTE: A page for /ncov does not exist because it is handled by the | ||
| // Express-level router. |
Contributor
There was a problem hiding this comment.
Huh, interesting this is causing a Type error in CI. I think removing the static-site/app/ncov/page.tsx file but keeping the nested /ncov/[...path] should still work and appease the type check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This applies the restructuring from #1274 to the rest of the codebase.
Related issue(s)
Follow-up to #1274
Checklist
/community/[[...community]/groups