Skip to content

Conversation

@letmehateu
Copy link

Before opening your pull request, please respond to the following prompts.

Is this resolving a feature or a bug?

NB: We DO NOT accept typo fixes. Generally, we do not accept edits to comments (starting with //) or minor grammatical and technical edits more generally, but do accept substantive fixes and improvements to the content of documentation comments (///) and README files.

Are there existing issue(s) that this PR would close?

If this PR is not minimal (it could be split into multiple PRs), please explain why the issues are best resolved together.

Describe your changes

Refactors ram_init_final.rs to replace hardcoded byte indices [0], [1], [2], [3] with helper functions using WORD_SIZE/WORD_SIZE_HALVED constants.

Changes:

  • Added bytes_to_word_halves() helper function for evaluation context

  • Added bytes_to_word_halves_packed() for optimized trace generation

  • Replaced hardcoded indices in 4 functions: constrain_add_initial_values, constrain_subtract_final_values, add_initial_values, subtract_final_values

@github-actions
Copy link

github-actions bot commented Nov 22, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@letmehateu
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

@letmehateu
Copy link
Author

recheck

@sjudson sjudson requested a review from slumber November 24, 2025 14:13
@slumber
Copy link
Contributor

slumber commented Nov 26, 2025

Thank you for the PR. This code mirrors the memory checking component.

@slumber slumber closed this Nov 26, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants