Fix pointer state update order in Clay_SetPointerState hover dispatch#587
Open
Harry-425 wants to merge 1 commit into
Open
Fix pointer state update order in Clay_SetPointerState hover dispatch#587Harry-425 wants to merge 1 commit into
Harry-425 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This changes
Clay_SetPointerStatesocontext->pointerInfo.stateis updated before ephemeral memory initialization and hover callback traversal.Problem
Clay_OnHovercallbacks can readpointerInfo.stateto detect click/press events. Previously, callbacks were invoked whilepointerInfo.statestill held the previous frame state; the new state was written only after traversal. This caused handlers that checkCLAY_POINTER_DATA_PRESSED_THIS_FRAMEto miss a first click and react only on a follow-up frame.Fix
newStatefrom current state +isPointerDown.context->pointerInfo.positionandcontext->pointerInfo.state = newStatebeforeClay__InitializeEphemeralMemory(context)and DFS traversal.Impact
Notes
This was validated in a WASM app using Clay where button handlers inspect
pointerInfo.state == CLAY_POINTER_DATA_PRESSED_THIS_FRAME.