FIX: Add .bidsignore file writing
#240
Conversation
Resolves: #239.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| write_derivative_description( | ||
| config.execution.bids_dir, | ||
| config.execution.output_dir, | ||
| dataset_links=config.execution.dataset_links, | ||
| ) | ||
| write_bidsignore(config.execution.output_dir) |
There was a problem hiding this comment.
The new calls to write_derivative_description and write_bidsignore now use config.execution.output_dir instead of config.execution.dmriprep_dir. In the legacy output layout, output_dir points to the derivatives root while dmriprep_dir is the actual dMRIPrep subdirectory. This change writes dataset_description.json and .bidsignore one level too high, so the dMRIPrep derivative no longer contains its own metadata and the ignore file applies to every derivative under the parent folder. Users who choose the legacy layout will end up with a non-BIDS-compliant dMRIPrep folder and potentially unexpected ignores for other pipelines.
Useful? React with 👍 / 👎.
Resolves: #239.