Disposes all streams#4
Open
Tustin wants to merge 3 commits into
Open
Conversation
njames93
requested changes
Mar 7, 2017
Owner
njames93
left a comment
njames93
left a comment
There was a problem hiding this comment.
Please change the spaces back to tabs. Its how the rest of the project is (should be?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made it so all the loadfile and savefile methods have their streams wrapped in using blocks so it will auto dispose and close all streams when finished. There was a bug with one of the loadfiles (I think for nativeinfo.dat) which would cause a crash when trying to create another stream on the same file for saving because loadfile wasn't closed properly.
Also sorry for the whole file being "edited", that was due to the original formatting and my bad habit of ctrl E + D 😛