fix: dont check version format when binary version is specified #762
Conversation
aduh95
force-pushed
the
fix/dont_check_version_format
branch
2 times, most recently
from
2f796d3 to
e6b00b8
Compare
|
Could you try to re-use versions we already use in tests (i.e. [email protected], [email protected]) to limit the increase in size of the nock file? |
aduh95
force-pushed
the
fix/dont_check_version_format
branch
from
093dc2a to
e6b00b8
Compare
Done. |
|
We can ignore the timeouts (failed tests)? Because we can see timeouts frequently if we look through the git history. |
| // When user specifies exact version, it should work despite range version in devEngines | ||
| await expect(runCli(cwd, [`[email protected]`, `--version`])).resolves.toMatchObject({ | ||
| exitCode: 0, | ||
| stderr: ``, | ||
| stdout: `6.14.2\n`, | ||
| }); |
There was a problem hiding this comment.
Is that what we want? This feels a bit odd
There was a problem hiding this comment.
I think so; it's handy when you need to quickly test a command across different versions of the same tool.
There was a problem hiding this comment.
But if that version doesn't match the supported range, why would you need to test with it? Either the version is supported, and the range should include it; either it's not, and there's no point testing with it (and you can still use COREPACK_ENABLE_PROJECT_SPEC=0 if you don't want Corepack to enforce it)
| stdout: `6.14.2\n`, | ||
| }); | ||
|
|
||
| // Test with other package managers too |
There was a problem hiding this comment.
Maybe it'd be better to split it, it would make debugging easier if the test ever starts failing for a specific package manager in the future
4 participants
Fix #760