Remove redundancy in node.config schema keys for test and watch #60943
+32
−243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
marco-ippolito
requested changes
Dec 3, 2025
Member
There was a problem hiding this comment.
This change removes the test and watch namespaces completely.
This is not what #60904 is about, it should only remove the test- prefix from keys.
The commit breaks many tests, run make test. Also it does not respect the commit guidelines, should be "lib: remove prefix from node.config.json namespaces" or something like that
Moreover I believe it should be an alias and not forbid the test- completely.
Author
|
okay i will go through the issue and guidelines again, will update the codebase |
Contributor
|
In addition of what Marco said, please add tests and PR description |
IlyasShabi
reviewed
Dec 3, 2025
| } | ||
| } | ||
| }, | ||
| "test": { |
Contributor
There was a problem hiding this comment.
I think we supposed to remove the prefix instead of the whole namespace no?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.