-
-
Notifications
You must be signed in to change notification settings - Fork 34.4k
sqlite: enable Percentile extension #61295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
sqlite: enable Percentile extension #61295
Conversation
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #61295 +/- ##
==========================================
- Coverage 88.53% 88.51% -0.02%
==========================================
Files 704 704
Lines 208759 208739 -20
Branches 40281 40278 -3
==========================================
- Hits 184816 184775 -41
- Misses 15947 15981 +34
+ Partials 7996 7983 -13 🚀 New features to boost your workflow:
|
2ba1db0 to
86b8170
Compare
|
Since you worked on #57621 and this PR follows the same pattern, could you take a look at this? |
|
Since this is not getting any activity lately, could you take a look at it so things get moving again? |
cjihrig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM
Sorry for the delay. LGTM |
Refs: #60618
This enables the SQLite Percentile extension added to the amalgamation with the release of SQLite v3.51.0 (#60614) by adding the
SQLITE_ENABLE_PERCENTILEflag to both the GYP and GN SQLite builds.The changes were made by following the pattern set by #57621.
This also addresses a minor review comment left unhandled in #57621 (comment).
A new test was added to
test/parallel/test-sqlite.jsto verify that thepercentile()function is available at runtime. The test is placed immediately after the existing math functions test for two reasons:SQLITE_ENABLE_PERCENTILEfollowsSQLITE_ENABLE_MATH_FUNCTIONSalphabetically in the build configuration.percentile()is logically related to the mathematical function set.This change does not enable the mentioned Carray extension from #60618 and does not include the
SQLITE_ENABLE_ORDERED_SET_AGGREGATESflag for enabling theWITHIN GROUPsyntax. Those are left for separate discussion and follow-up.