chore(ci): resolve scan-vulns CI failures by updating Go, deps, and Trivy#2522
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to unblock the failing scan-vulns GitHub Actions workflow by upgrading the Go toolchain/dependencies to address govulncheck findings, and by updating Trivy plus its CLI flags/config.
Changes:
- Bump the module’s
godirective and upgrade a large set of dependencies ingo.modto remediate reported vulnerabilities. - Update
scan-vulns.yamlto use a newer Go version for govulncheck. - Update Trivy to
0.70.0and modernize Trivy CLI flags used in repository/image scans.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
go.mod |
Raises the minimum Go version and updates dependencies to address govulncheck findings. |
.github/workflows/scan-vulns.yaml |
Updates Go/Trivy versions and Trivy invocation flags to fix scan-vulns CI failures. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
not ratify code change, ci related should start with |
|
need approval from maintainer to trigger the ci test |
5a75cce to
94724c7
Compare
89e4ab9 to
b1d6f20
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2522 +/- ##
=======================================
Coverage 77.10% 77.10%
=======================================
Files 105 105
Lines 4657 4657
=======================================
Hits 3591 3591
Misses 917 917
Partials 149 149 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5a3df2b to
a5d8f67
Compare
Signed-off-by: Yitong Feng <yife@microsoft.com>
Description
The
scan-vulnsCI workflow is failing on all PRs due to known vulnerabilitiesdetected by govulncheck and outdated Trivy configuration.
This PR fixes both jobs in
scan-vulns.yaml:govulncheck:
go-versionfrom1.22to1.26(was already out of date with go.mod)godirective in go.mod to1.26to fix 17 stdlib vulnerabilitiesgo.opentelemetry.io/otel/sdkv1.38.0 → v1.43.0 (GO-2026-4394)golang.org/x/netv0.43.0 → v0.54.0 (GO-2026-4918)github.com/theupdateframework/go-tuf/v2v2.2.0 → v2.4.1github.com/sigstore/rekorv1.4.2 → v1.5.0github.com/sigstore/sigstore-gov1.1.3 → v1.1.4Trivy (scan_vulnerabilities):
0.58.2to0.70.0--vuln-typeflag with--pkg-types--skip-db-updateso Trivy can download the DB when cache is unavailableWhich issue(s) does this PR resolve?
Fixes scan-vulns CI workflow failures blocking all PRs.
Type of change
Testing and verification
govulncheck ./...reports 0 called vulnerabilities locallygo build ./...passesgo test ./...passes (except pre-existinginternal/controllerwhich requires kubebuilder binaries)Checklist
Post merge requirements
Helm Chart Change