Skip to content

Do not hard fail upon duplicated plugins #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martinRenou wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Do not hard fail upon duplicated plugins #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions app/index.template.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ async function createModule(scope, module) {
* The main entry point for the application.
*/
export async function main() {
const allPlugins = [];
const allPlugins = [];
const pluginsToRegister = [ pathsPlugin, translatorPlugin, ...spectaPlugins ];
const federatedExtensionPromises = [];
const federatedMimeExtensionPromises = [];
Expand Down Expand Up @@ -202,7 +202,13 @@ export async function main() {
const pluginRegistry = new PluginRegistry();

// 2. Register the plugins
pluginRegistry.registerPlugins(pluginsToRegister);
for (const plugin of pluginsToRegister) {
try {
pluginRegistry.registerPlugin(plugin);
} catch(e) {
console.error(e);
}
}

// 3. Get and resolve the service manager and connection status plugins
const IServiceManager = require('@jupyterlab/services').IServiceManager;
Expand Down
Loading