fix(api): translation DTOs/OAS for SDK auto-gen; idempotency fixes NV-6903 #9515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dashboard-v2-novu-staging canceled.
|
github-actions
bot
changed the title
ChmaraX
changed the title
ChmaraX
deleted the
nv-6903-apisdk-translations-upload-methods-have-incorrectly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
EE PR: https://github.com/novuhq/packages-enterprise/pull/376
This pull request introduces several updates to the internal SDK, focusing on improved file upload handling, schema and type cleanup, and configuration enhancements. The most significant changes are the refactoring of translation upload functions to support more flexible file inputs and updates to the code generation configuration for better SDK output.
File Upload Handling Improvements
translationsUploadandtranslationsMasterUploadfunctions to accept a new request body type, supporting both Blob-like objects and readable streams for file uploads, and improved FormData construction for various file input scenarios. (libs/internal-sdk/src/funcs/translationsUpload.ts,libs/internal-sdk/src/funcs/translationsMasterUpload.ts) [1] [2] [3] [4]Bug Fixes and Robustness
apps/api/src/app/shared/framework/idempotency.interceptor.ts)Subproject Update
.source)