Skip to content

Implement IntersectsBbox to translate PostGIS && operator #3484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
roji merged 25 commits into from
Feb 2, 2026
Merged

Implement IntersectsBbox to translate PostGIS && operator #3484

roji merged 25 commits into from
Feb 2, 2026

Conversation

@bjornharrtell
Copy link
Contributor

@bjornharrtell bjornharrtell commented Mar 1, 2025 •
edited by roji
Loading

Implement a DbFunction to translate into PostGIS && operator.

Closes #3485

roji and others added 19 commits November 18, 2024 16:30
@roji
Bump version to 9.0.1
7aa8be0
@roji
Depend on Npgsql 9.0.1 (npgsql#3376)
2e9a27f 
(cherry picked from commit 773a330)
@roji
Bump version to 9.0.2
051d00c
@virzak @roji
Restore virtual modifier (npgsql#3382)
17e2fc8 
(cherry picked from commit c6fb5e2)
@roji
Bump Npgsql dependency to 9.0.2
697dd71
@roji
Bump version to 9.0.3
e5e901e
@roji
Redo enum label addition (npgsql#3425)
c240ce5 
To better handling reordering scenarios.

Fixes npgsql#3424

(cherry picked from commit c2b3de4)
@roji
Fix quoted enum handling (npgsql#3434)
2e59bf5 
Fixes npgsql#3433

(cherry picked from commit 068a7c6)
@roji
Depend on EF 9.0.1
74b858a
@roji
Bump version to 9.0.4
e4a74e7
@roji
Fix calling base method in NpgsqlMigrationsSqlGenerator (npgsql#3443)
badb51e 
Fixes npgsql#3440

(cherry picked from commit 83f2cc3)
@roji
Generate UUIDv7 values for value-generated strings (npgsql#3462)
953ad1c 
Fixes npgsql#3460

(cherry picked from commit 16841f9)
@roji
Stop testing on PG12 (out of support)
e952c84 
(cherry picked from commit 3cbdba4)
@marcusber @roji
Always close connection after reloading types in migration. (npgsql#3465
6a34455 
)

Closes npgsql#3464

(cherry picked from commit 786b635)
@roji
Fix nullability for IndexOf (array_position) (npgsql#3477)
0fdf784 
Fixes npgsql#3474

(cherry picked from commit 0212cae)
@roji
Preserve collation when changing column type (npgsql#3479)
4bf3248 
Fixes npgsql#3476

(cherry picked from commit e327d6b)
@roji
Preserve ConfigureDataSource() callback when applying other context o…
80ec4ae 
…ptions (npgsql#3482)

Fixes npgsql#3478

(cherry picked from commit 0db010c)
@roji
Bump Npgsql to 9.0.3
fd23809
@bjornharrtell
Attempt to implement IntersectsBbox
5da4a58
@bjornharrtell bjornharrtell mentioned this pull request Mar 1, 2025
Closed
@bjornharrtell
Copy link
Contributor Author

bjornharrtell commented Mar 1, 2025 •
edited
Loading

I'm getting test failure:

Npgsql.EntityFrameworkCore.PostgreSQL.Query.SpatialQueryNpgsqlGeometryTest.IntersectsBbox(async: False) (24ms): Error Message: System.InvalidOperationException : The 'IntersectsBbox' method is not supported because the query has switched to client-evaluation. This usually happens when the arguments to the method cannot be
translated to server. Rewrite the query to avoid client evaluation of arguments so that method can be translated to server.

But at the same time I see:

SQL sent to the database:
       @__polygon_1='POLYGON ((0 0, 1 0, 0 1, 0 0))' (DbType = Object)
       
       SELECT p."Id", p."Polygon" && @__polygon_1 AS "IntersectsBbox"
       FROM "PolygonEntity" AS p

The generated SQL looks fine... so I'm quite confused about why the test is failing with what looks like something that should block SQL generation!?

@bjornharrtell
Copy link
Contributor Author

bjornharrtell commented Mar 1, 2025

I understand now, in the case of DbFunction extensions I need to emulate a client side query in the test case. Should be foxed now.

@bjornharrtell bjornharrtell marked this pull request as ready for review March 1, 2025 15:28
@bjornharrtell bjornharrtell changed the title Attempt to implement IntersectsBbox Implement IntersectsBbox to translate PostGIS && operator Mar 1, 2025
@bjornharrtell bjornharrtell changed the base branch from hotfix/9.0.5 to main January 31, 2026 23:56
@bjornharrtell bjornharrtell changed the base branch from main to hotfix/9.0.5 January 31, 2026 23:56
@bjornharrtell bjornharrtell changed the base branch from hotfix/9.0.5 to main February 1, 2026 16:38
Copilot AI review requested due to automatic review settings February 1, 2026 16:41
Copilot AI reviewed Feb 1, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for PostGIS's bounding box intersection operator (&&) by implementing an IntersectsBbox DbFunction. The implementation includes the function definition, query translation logic, and comprehensive test coverage.

Changes:

  • Added IntersectsBbox extension method to DbFunctions for checking bounding box intersections
  • Implemented translation to PostGIS && operator in the method call translator
  • Added test case validating the function behavior and SQL generation

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.

File Description
src/EFCore.PG.NTS/Extensions/NpgsqlNetTopologySuiteDbFunctionsExtensions.cs Adds the IntersectsBbox DbFunction extension method
src/EFCore.PG.NTS/Query/ExpressionTranslators/Internal/NpgsqlNetTopologySuiteMethodCallTranslatorPlugin.cs Implements translation of IntersectsBbox to PostGIS && operator
test/EFCore.PG.FunctionalTests/Query/SpatialQueryNpgsqlGeometryTest.cs Adds test coverage for the new IntersectsBbox function

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

roji
roji approved these changes Feb 1, 2026
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@roji roji enabled auto-merge (squash) February 1, 2026 20:29
@roji
Copy link
Member

roji commented Feb 1, 2026

@bjornharrtell note test failures, looks like you need to adjust the SQL assertion which changed since your wrote this.

Copilot AI review requested due to automatic review settings February 1, 2026 22:03
auto-merge was automatically disabled February 1, 2026 22:03

Head branch was pushed to by a user without write access

Copilot AI reviewed Feb 1, 2026
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@bjornharrtell
Copy link
Contributor Author

bjornharrtell commented Feb 1, 2026

@roji sorry, should be fixed now.

@roji roji enabled auto-merge (squash) February 2, 2026 07:59
@roji roji merged commit 98d0671 into npgsql:main Feb 2, 2026
10 checks passed
@roji
Copy link
Member

roji commented Feb 2, 2026

Thanks for your contribution!

@bjornharrtell bjornharrtell deleted the intersects-bbox branch February 2, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@roji roji roji approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Translation for PostGIS && operator

4 participants

@bjornharrtell @roji @virzak @marcusber