-
-
Notifications
You must be signed in to change notification settings - Fork 365
fix: resolve multiple UI, UX, and a11y issues #2201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
ebc0cb3
feat: add word wrap toggle to code viewer (#2027)
thealxlabs 41d2a34
fix(ui): fix dropdown z-index and search layout stability on focus (#β¦
thealxlabs 8e619f1
fix: show version-specific license, no-deps empty state, layout stabiβ¦
thealxlabs b23fd4b
fix: exclude CodePen profile pages from playground links (#2110)
thealxlabs 516ee88
feat: add package dependents list page (#2036)
thealxlabs 662c37f
fix: show copy buttons on touch devices (#1771)
thealxlabs ca144b1
fix: improve compare bar chart skeleton loaders with varying widths (β¦
thealxlabs a657927
fix: collapsible section title now toggles instead of scrolling (#151β¦
thealxlabs 13eacb0
feat: reorganize footer links into product/legal/community columns (#β¦
thealxlabs 6e345ad
fix: add pointer cursor to ButtonBase (#1760)
thealxlabs bd8fa38
fix: cap pagination page count to max fetchable results (#1923)
thealxlabs 727f305
fix: add back button to blog page (#2022)
thealxlabs a7d3613
fix: link aliased dependencies to their real package (#2010)
thealxlabs 71785d6
fix: resolve CI failures (unused imports, type errors, i18n schema, aβ¦
thealxlabs d704602
[autofix.ci] apply automated fixes
autofix-ci[bot] 29974e5
fix(a11y): add aria-expanded and aria-controls to collapsible title bβ¦
thealxlabs 72baa25
fix(a11y): remove redundant aria-label from collapsible title button
thealxlabs ece3b66
fix(a11y): match copy button aria-label to its visible text
thealxlabs 4fe4145
[autofix.ci] apply automated fixes
autofix-ci[bot] d2f86d2
Update Base.vue
thealxlabs 0f63f0e
[autofix.ci] apply automated fixes
autofix-ci[bot] 99322d5
fix(a11y): increase provenance link touch target size to meet 24px miβ¦
thealxlabs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Expose disclosure semantics on the title toggle button.
This button also controls the collapsible content, but it currently omits the standard
aria-expandedandaria-controlsrelationship/state on this control.Suggested fix
<button type="button" class="text-start focus-visible:outline-accent/70 rounded" - :aria-label="`${isOpen ? 'Collapse' : 'Expand'} ${title}`" + :aria-expanded="isOpen" + :aria-controls="contentId" + :aria-label="ariaLabel" `@click`="toggle" >π Committable suggestion