fix(cli): force npmjs registry for login and npm cli operations#2213
fix(cli): force npmjs registry for login and npm cli operations#2213ghostdevv merged 3 commits intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe changes centralise npm subprocess environment configuration and ensure npm operations target the npmjs registry. A new exported Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
there's some info here on that env var for posterity: https://docs.npmjs.com/cli/v10/using-npm/config#environment-variables |
|
Thanks for your first contribution, @MathurAditya724! ⭐ We'd love to welcome you to the npmx community. Come and say hi on Discord! And once you've joined, visit npmx.wamellow.com to claim the contributor role. |
🔗 Linked issue
Fixes #2179
🧭 Context
npmx-connectorshould always operate against npmjs. If a user has a customregistryin.npmrc, login and follow-up npm commands can target a mirror, which breaks connector expectations.📚 Description
--registry=https://registry.npmjs.org/npm_config_registry=https://registry.npmjs.org/for npm command execution paths:packageInit)