claude-desktop: add desktop file & uri handler #917
Conversation
|
Interesting bug you triggered in nix: terminate called after throwing an instance of 'boost::wrapexceptboost::io::too_few_args' |
The true power of vibe coding. |
Mic92
force-pushed
the
claude/add-desktop-file-uri-handler-011CV2EdMBPhK5SCUVcp7JFU
branch
from
28cbc1f to
08d39d5
Compare
packages/claude-desktop/package.nix
Outdated
| # Install icon | ||
| mkdir -p $out/share/icons/hicolor/scalable/apps | ||
| cp ${icon} $out/share/icons/hicolor/scalable/apps/claude-desktop.svg |
There was a problem hiding this comment.
After manual review, this line (194) is the culprit. Perhaps the icon path has a character boost really doesn't like when interpolating nix to bash?
|
Looks like the checks are now passing, the latest commit uses the icon available in the installer's exe, which is better than fetching an svg from Wikimedia anyway. |
packages/claude-desktop/package.nix
Outdated
| 7z x -y $src -o./extracted | ||
| # Extract and convert icon to multiple PNG sizes | ||
| if [ -f ./extracted/setupIcon.ico ]; then |
There was a problem hiding this comment.
@copilot we don't need this code here and than we loop over icons in the installPhase again. Just do the conversion in install phase in one loop. Also use graphicsmagic instead of imagemagic.
- Add desktop entry with MIME type handler for claude:// URIs - Extract and convert icon from Windows installer to multiple PNG sizes - Use GraphicsMagick for icon conversion (lighter than ImageMagick) - Consolidate icon conversion and installation into single loop in installPhase - Install icons to standard hicolor theme directories - Skip low-quality small icons (16x16, 32x32) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
baduhai
force-pushed
the
claude/add-desktop-file-uri-handler-011CV2EdMBPhK5SCUVcp7JFU
branch
from
b9d8210 to
8007a4e
Compare
2 participants
This pr adds a desktop file for the claude-desktop package. The desktop package alse makes the program handle the claude:// uri.