[Zhitong] ip #110
Open
[Zhitong] ip #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RCPilot1604
reviewed
Sep 4, 2024
| public void accept(String nextLine) { | ||
|
|
||
| int index = (nextLine.indexOf(' ')); | ||
| String commandKeyword = (index == -1)? nextLine : nextLine.substring(0, index).trim(); |
There was a problem hiding this comment.
Should there be a space before the "?" ternary operator?
| @@ -0,0 +1,6 @@ | |||
|
|
|||
| public class Texts { | |||
| public static final String GREETINGS = " hello"; | |||
There was a problem hiding this comment.
I like how you use all caps for constants.
| @Override | ||
| public String toString() { | ||
| return "[" + (isDone? "X" : " ") + "]" | ||
| + line; |
There was a problem hiding this comment.
Shouldn't this be on the same line (line limit 110 characters)?
| int index = (nextLine.indexOf(' ')); | ||
| String commandKeyword = (index == -1)? nextLine : nextLine.substring(0, index).trim(); | ||
|
|
||
| final String commandText = (index == -1)? nextLine : nextLine.substring(index).trim(); |
There was a problem hiding this comment.
Shouldn't you extract this magic number?
|
|
||
| public int length = 0; | ||
|
|
||
| private boolean isExited = false; |
There was a problem hiding this comment.
Shouldn't the private attributes be grouped together?
okkhoy
reviewed
Sep 27, 2024
okkhoy
left a comment
okkhoy
left a comment
There was a problem hiding this comment.
not much code to review.
do not track binary files in git.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.