fix: change from english to indonesian

[nusendra]

No description provided.

[nusendra]

Code Review

Status Logic Changes (Lines 17, 19)

Line 17: The translation from 'Incoming' to 'Mendatang' is appropriate for Indonesian localization.

Line 19: The translation ' yang sudah selesai' has a leading space which will create inconsistent spacing in the UI. Consider removing the leading space and handling the sentence structure in the template instead.

Template Structure Issues (Lines 99-103)

Line 99: The span element now contains excessive whitespace and line breaks that will affect rendering and code readability.

Line 103: The text structure "Acara {status}" works well for "Acara Mendatang" but creates awkward phrasing for "Acara yang sudah selesai". Consider restructuring the Indonesian translations to maintain consistent grammar.

Recommendations

1. Fix spacing issue: Remove the leading space from ' yang sudah selesai'
2. Clean up template: Remove unnecessary whitespace in the span element
3. Consider grammar consistency: Use consistent sentence structures for all status translations
4. Suggested translations:
   • 'Incoming' → 'Mendatang'
   • 'Past' → 'Selesai' (instead of ' yang sudah selesai')
   • 'Current' → 'Berlangsung'

---

Pull Request Documentation

Title

Localize event status text to Indonesian

Description

This pull request implements Indonesian localization for event status indicators in the main page component.

Changes Made

• Internationalization: Translated event status text from English to Indonesian
  • "Incoming" → "Mendatang"
  • "Past" → " yang sudah selesai"
• Template Updates: Modified the display template to use "Acara {status}" format

Files Modified

• src/routes/+page.svelte: Updated status logic and template display

Testing Considerations

• Verify text rendering for all three status states (Current, Incoming, Past)
• Check UI layout with longer Indonesian text
• Ensure proper spacing and grammar in displayed text

Notes

• Current status remains "Current" (may need future localization)
• Template structure includes extra whitespace that should be cleaned up
• Consider reviewing Indonesian grammar for natural sentence flow

[nusendra]

Code Review

Status Logic Changes (Lines 17 & 19)

Line 17: status = 'Mendatang';

• ✅ Good: Translation to Indonesian is consistent with the internationalization effort
• ⚠️ Consider: Ensure this translation is consistent across the entire application and matches your i18n standards

Line 19: status = ' yang sudah selesai';

• ❌ Issue: Leading whitespace in the string will cause inconsistent spacing when concatenated
• ❌ Issue: This translation is verbose compared to the original "Past" - consider a more concise alternative like "Selesai" or "Berakhir"
• 🔧 Recommendation: Remove leading space and use a shorter translation

Template Formatting Issues (Lines 99-103)

Lines 99-103: Template structure with excessive whitespace

<span>



                        Acara {status}</span>

• ❌ Major Issue: Unnecessary blank lines and inconsistent indentation harm code readability
• ❌ Issue: The excessive whitespace will render as visible whitespace in the browser
• 🔧 Recommendation: Clean up formatting to: <span>Acara {status}</span>

Translation Consistency (Line 103)

Line 103: Acara {status} pattern

• ✅ Good: Consistent Indonesian translation approach
• ⚠️ Consider: With the current status values, you'll get "Acara Mendatang" and "Acara yang sudah selesai" - the latter sounds awkward
• 🔧 Recommendation: Adjust status strings to work better with the "Acara" prefix

---

Pull Request Documentation

📋 Summary

This PR implements Indonesian language localization for the event status display component, translating English status labels to Indonesian equivalents.

🔄 Changes Made

• Localization: Converted event status strings from English to Indonesian
  • "Incoming" → "Mendatang"
  • "Past" → " yang sudah selesai"
• Template: Updated display text from "Event" to "Acara"

🐛 Issues Identified

1. Whitespace Problem: Leading space in " yang sudah selesai" will cause display issues
2. Code Formatting: Excessive blank lines and poor indentation in template
3. Translation Quality: "Acara yang sudah selesai" sounds verbose and unnatural

🔧 Recommended Fixes

// Suggested status values:
status = 'Mendatang';        // ✅ Good as-is
status = 'Selesai';          // ✅ Better than current
// Or alternatively:
status = 'Berakhir';         // ✅ Alternative option

<!-- Clean template formatting: -->
<span>Acara {status}</span>

🧪 Testing Requirements

• Verify text rendering for all three status states
• Check for unwanted whitespace in browser
• Validate Indonesian grammar and natural language flow
• Ensure consistent styling across different status lengths

📝 Notes

Consider implementing a proper i18n solution (like svelte-i18n) for better maintainability if this is part of a larger localization effort.