add gestures for cycling magnifier full screen focus mode and color filters#19464
add gestures for cycling magnifier full screen focus mode and color filters#19464
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds keyboard gestures for cycling through magnifier color filters and focus tracking modes, addressing a gap where these features lacked default key bindings. It also standardizes the capitalization of "NVDA" in gesture definitions throughout the magnifier-related commands.
Changes:
- Added
NVDA+shift+igesture for cycling through magnifier color filters - Added
NVDA+shift+ugesture for cycling through magnifier focus tracking modes - Standardized gesture capitalization from "nvda" to "NVDA" in magnifier commands
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| source/globalCommands.py | Added gesture bindings for toggleFilter and toggleFullscreenMode scripts, and standardized NVDA capitalization in gesture definitions |
| user_docs/en/userGuide.md | Updated documentation to reflect new keyboard gestures in command tables and removed references to needing custom gestures |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I agree with Sascha that keeping unassigned focus tracking mode for now is better. Actually, if we should toggle something regarding tracking, I'd better implement a global toggle tracking and / or individual toggle for mouse tracking, focus tracking and navigator object tracking. That's not part of Windows Magnifier scripts, but I have implemented similar gestures (toggle globally tracking, toggle focus tracking, toggle mouse tracking and toggle caret tracking) in Windows Magnifier NVDA add-on improvements. And being able to toggle tracking globally or partially on the fly (i.e. without needing to open Windows Magnifier settings) proves to be very useful. For now, I'd recommend only the filter cycling gesture (NVDA+shift+I). |
Link to issue number:
Follow up to #19228
Summary of the issue:
Gestures weren't bound for changing filters
Description of user facing changes:
Adds
NVDA+shift+ifor changing filtersDescription of developer facing changes:
N/a
Description of development approach:
Testing strategy:
test gestures
Known issues with pull request:
Code Review Checklist: