Skip to content

add gestures for cycling magnifier full screen focus mode and color filters#19464

Merged
seanbudd merged 4 commits intomasterfrom
fixMagGestures
Feb 6, 2026
Merged

add gestures for cycling magnifier full screen focus mode and color filters#19464
seanbudd merged 4 commits intomasterfrom
fixMagGestures

Conversation

@seanbudd
Copy link
Member

@seanbudd seanbudd commented Jan 19, 2026

Link to issue number:

Follow up to #19228

Summary of the issue:

Gestures weren't bound for changing filters

Description of user facing changes:

Adds NVDA+shift+i for changing filters

Description of developer facing changes:

N/a

Description of development approach:

  • fixed up gesture capitalisation
  • added gestures

Testing strategy:

test gestures

Known issues with pull request:

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds keyboard gestures for cycling through magnifier color filters and focus tracking modes, addressing a gap where these features lacked default key bindings. It also standardizes the capitalization of "NVDA" in gesture definitions throughout the magnifier-related commands.

Changes:

  • Added NVDA+shift+i gesture for cycling through magnifier color filters
  • Added NVDA+shift+u gesture for cycling through magnifier focus tracking modes
  • Standardized gesture capitalization from "nvda" to "NVDA" in magnifier commands

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
source/globalCommands.py Added gesture bindings for toggleFilter and toggleFullscreenMode scripts, and standardized NVDA capitalization in gesture definitions
user_docs/en/userGuide.md Updated documentation to reflect new keyboard gestures in command tables and removed references to needing custom gestures

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@SaschaCowley SaschaCowley added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Jan 20, 2026
@SaschaCowley SaschaCowley added this to the 2026.2 milestone Jan 29, 2026
@CyrilleB79
Copy link
Contributor

I agree with Sascha that keeping unassigned focus tracking mode for now is better.

Actually, if we should toggle something regarding tracking, I'd better implement a global toggle tracking and / or individual toggle for mouse tracking, focus tracking and navigator object tracking. That's not part of Windows Magnifier scripts, but I have implemented similar gestures (toggle globally tracking, toggle focus tracking, toggle mouse tracking and toggle caret tracking) in Windows Magnifier NVDA add-on improvements. And being able to toggle tracking globally or partially on the fly (i.e. without needing to open Windows Magnifier settings) proves to be very useful.
But that may be another PR.

For now, I'd recommend only the filter cycling gesture (NVDA+shift+I).

@seanbudd seanbudd marked this pull request as draft February 3, 2026 03:39
@seanbudd seanbudd marked this pull request as ready for review February 4, 2026 03:11
Copy link
Member

@Qchristensen Qchristensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reads well

@seanbudd seanbudd merged commit f83b34b into master Feb 6, 2026
41 of 43 checks passed
@seanbudd seanbudd deleted the fixMagGestures branch February 6, 2026 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants