Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the solution's target framework to .NET 8 and adjusts related build configuration and documentation accordingly.
- Updated DotNetVersion, UnoCheck_Version, and UnoCheck_Manifest in build/stage-build.yml for .NET 8 support.
- Added breaking changes notes in BREAKING_CHANGES.md indicating support for .NET 8 and removal of .NET 7.
Reviewed Changes
Copilot reviewed 2 out of 7 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| build/stage-build.yml | Updated build configuration for .NET 8 support. |
| BREAKING_CHANGES.md | Documented breaking changes for framework upgrade. |
Files not reviewed (5)
- src/BackButtonManager.Abstractions/BackButtonManager.Abstractions.csproj: Language not supported
- src/BackButtonManager.Tests/BackButtonManager.Tests.csproj: Language not supported
- src/BackButtonManager.Uno.WinUI/BackButtonManager.Uno.WinUI.csproj: Language not supported
- src/BackButtonManager.Uno.WinUI/winappsdk-workaround.targets: Language not supported
- src/BackButtonManager/BackButtonManager.csproj: Language not supported
juliecantin
approved these changes
Apr 2, 2025
carlh98
reviewed
Apr 2, 2025
src/BackButtonManager.Abstractions/BackButtonManager.Abstractions.csproj
Show resolved
Hide resolved
jeanplevesque
approved these changes
Apr 2, 2025
Lee31416
approved these changes
Apr 2, 2025
882a5e8 to
62a1de9
Compare
carlh98
approved these changes
Apr 2, 2025
ba5c63d to
f6e4a75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #
Proposed Changes
What is the current behavior?
Projects in the solution target .NET 6-7 and C# 10-11.
What is the new behavior?
Projects in the solution target .NET 8 and C# 12.
Impact on version
buildfolder was changed..githubfolder was changed.Checklist
Please check that your PR fulfills the following requirements:
Other information