Improvements for LPSPI driver#43
Open
SiarheiVolkau wants to merge 2 commits into
Open
Conversation
The driver currently doesn't support SPI_LSB_FIRST feature but it can be easily added. Signed-off-by: Siarhei Volkau <lis8215@gmail.com>
In DMA mode LPSPI splits out transaction on per-word basis. This is because TCR_CONT is not set. When TCR_CONT set, it starts work properly. However, CS stays active much longer than required, for ~80us on imx95. I guess DMA completion handler resets it. Also I observed that TCR_CONTC flag logic is broken but don't know how to fix it. Signed-off-by: Siarhei Volkau <lis8215@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here I present two patches which helped me bring up a custom i.MX95-based board.
Let me know if it is the right place for these patches, maybe better to add them into mainline first?
PS: Also I observed that
TCR_CONTCbit related logic is broken/misused, but have no idea how to fix that.