Skippable files - prevent certain deleted files from being recreated#61
Open
OscarBarrett wants to merge 1 commit intonystudio107:masterfrom
Open
Skippable files - prevent certain deleted files from being recreated#61OscarBarrett wants to merge 1 commit intonystudio107:masterfrom
OscarBarrett wants to merge 1 commit intonystudio107:masterfrom
Conversation
- DRYed up file writes - Added skippable property checks to skip the write if the full plugin is not being generated - Updated json configs to make markdown/text files, .gitignore, releases.json, translations and icons skippable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #55
Adds support for a
skippableproperty forTEMPLATE_FILESandBOILERPLATE_FILESitems.When running the generator for a previously generated plugin, files marked as skippable will not be recreated if they no longer exist.
At this stage I've marked the following files as skippable:
It might be worth considering whether to make twig, css and js files skippable as well (in case they were renamed or not required).
Currently there's no opt-in or out for this. I could add an option to ask the user whether they want to recreate skippable files or not.
I also haven't adjusted the output - we could report the skipped files to the user.