Update deps to support LTS node versions #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achavez
approved these changes
Jul 16, 2025
Contributor
achavez
left a comment
achavez
left a comment
There was a problem hiding this comment.
This all makes sense to me. Just flagged one potential change to reduce the risk to the deployed app a tiny bit, but defer to you on the final decision.
| @@ -1,4 +1,4 @@ | |||
| FROM node:18 | |||
| FROM node:24 | |||
Contributor
There was a problem hiding this comment.
Only question I have is whether it would be less risky to upgrade this to the latest LTS while still running the matrix tests to make sure we're ready to go all the way to the latest/current/active ... but defer 100% to you on that.
Member
Author
There was a problem hiding this comment.
Generally, I think we've unofficially tried to support the current version as our recommended version of node to use in deployments, but I do like the idea of using the matrix for smoke testing in the future!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Updates our dependencies to resolve errors and warnings when building with current versions of node. Swaps out
node-sassto use the non-deprecatedsassmodule, and makes necessary associated changes as outlined here, most of which were done using thesass-migratortool.Related Issue
Closes #362
Motivation and Context
We aim to continue to support the latest releases of node whenever possible!
Checklist
npm run lintand updated code style accordinglynpm run testpasses