Make postgres version check more lenient #1082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-boden
requested review from
ahadas,
bennyz,
didib,
emesika,
michalskrivanek,
sandrobonazzola,
sgratch and
smelamud
as code owners
JasperB-TeamBlue
approved these changes
Oct 20, 2025
Contributor
JasperB-TeamBlue
left a comment
JasperB-TeamBlue
left a comment
There was a problem hiding this comment.
Tested dev container on centos 9 & 10, both function with this fix.
dupondje
requested changes
Oct 21, 2025
DEVELOPMENT.adoc
Outdated
| For development on the setup itself it might be usefull to reset the setup. Do the following: | ||
| ``` | ||
| find $PREFIX -type f -name '*.conf' -path '*setup*' -ok sudo rm {} \; |
Member
There was a problem hiding this comment.
You could also add some 'make clean' or 'make clean-setup' or so.
| )[ | ||
| -1 | ||
| ], | ||
| 'ok': self._pg_versions_match, |
Member
There was a problem hiding this comment.
_pg_versions_match is not used anymore anywhere after this? Then drop the function.
peter-boden
force-pushed
the
postgres_check
branch
from
ca5cc2f to
b9675c7
Compare
Add install-setup-dev target to enable more rapid development of the engine-setup. The regular install-dev does the whole java build which is pretty slow. + add some info in dev doc regarding setup development. Add clean-seutp-conf target to cleanup the setup config files. Signed-off-by: Peter Boden <[email protected]>
The setup compares the local psql version with the postgresql server version. Instead of requiring them to be equal, just require that client major >= server major version. Signed-off-by: Peter Boden <[email protected]>
The PATH for e.g. ovirt-engine.py wasn't correct. Signed-off-by: Peter Boden <[email protected]>
peter-boden
force-pushed
the
postgres_check
branch
from
b9675c7 to
b174835
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced with this PR
*Add install-setup-dev target to Makefile to facilitate development on the setup
Are you the owner of the code you are sending in, or do you have permission of the owner?
y