Set progress text properly and runs the animation when the default progress is given#134
Open
mu29 wants to merge 2 commits intooblador:masterfrom
Open
Set progress text properly and runs the animation when the default progress is given#134mu29 wants to merge 2 commits intooblador:masterfrom
mu29 wants to merge 2 commits intooblador:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since
progressValueis set to 0 on constructor, initial progress value didn't works well when combine withanimatedandshowsTextprops. See code and screenshot below.Expected behavior
Text shows 10% in the progress circle
Solution
Run progress animation on
componentDidMount. This will not only update progress, but also animates progress circle to given default progress.