Add GC support for OCaml #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gretay-js
requested changes
Sep 17, 2025
gretay-js
left a comment
gretay-js
left a comment
There was a problem hiding this comment.
Please create a separate file for the oxcaml gc printer instead of changing the existing OCamlGCPrinter.
llvm/lib/IR/BuiltinGCs.cpp
Outdated
There was a problem hiding this comment.
This should be UsesMetadata = false according to the comments in GCStrategy.h and similar to other GCStrategy definitions that use statepoints.
There was a problem hiding this comment.
Discussed offline, this is intentional for AsmPrinter.
Comment on lines
3850
to
3851
There was a problem hiding this comment.
Consider calling ForceAsmWriterLinking here instead.
usuyus
force-pushed
the
oxcaml-statepoints
branch
from
04304ed to
ac745f8
Compare
gretay-js
reviewed
Sep 17, 2025
gretay-js
left a comment
gretay-js
left a comment
There was a problem hiding this comment.
The module flag trick is nice, we should do it for all module names, not just for the startup module.
usuyus
force-pushed
the
oxcaml-statepoints
branch
from
17124b5 to
d9145bf
Compare
gretay-js
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the pre-existing
GCStrategyandGCMetadataPrinterfor OCaml to trigger theRewriteStatepointsForGCpass and print frametables.