Constrain ocamlfind.1.9.8 to OCaml < 5.0.0 for MSYS2/Cygwin #28897
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocamlfind 1.9.8 doesn't configure correctly on MSYS2 or Cygwin when building with OCaml 5 onwards.
jmid
approved these changes
Nov 16, 2025
Member
jmid
left a comment
jmid
left a comment
There was a problem hiding this comment.
Good idea, thanks! 🙏
I wondered whether this would leave earlier ocamlfind versions to be picked up:
- 1.9.6 already has
available: os != "win32" - 1.9.5 and earlier versions already have a
< "5.0"bound (or something stricter)
So I guess that leaves 1.9.6 to be picked on "pure Cygwin" (os = "cygwin" & os-distribition = "cygwin"). However (a) we don't test pure Cygwin in the CI and (b) I don't know whether there are any problems with ocamlfind.1.9.6 on pure Cygwin 🤷
As such, this is a good step to reduce MSys2 CI noise until a next, patched ocamlfind is released 👍
Member
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no working version of ocamlfind for OCaml 5.0+ for Cygwin or when building using MSYS2 until ocaml/ocamlfind#112 is merged. Update the ocamlfind.1.9.8 package to reflect this, which should stop CI unnecessarily testing packages (and then causing those authors to incorrect constrain their packages away from MSYS2...)