fix(groups): trim whitespace in "Add user to group" email (Closes #1387)#1427
Closed
brianbckim wants to merge 4 commits intookpy:masterfrom
Closed
fix(groups): trim whitespace in "Add user to group" email (Closes #1387)#1427brianbckim wants to merge 4 commits intookpy:masterfrom
brianbckim wants to merge 4 commits intookpy:masterfrom
Conversation
…oads" This reverts commit 5f8e3ce.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: Closes #1387
Problem
Adding a user to a group failed when the email had leading/trailing spaces.
Fix
Add a WTForms filter to strip whitespace before validation in the staff add-member form.
(Optional) Defensive strip in the controller if applied.
Test
tests/test_staff_group_add_trim.py:
Env
pyenv Python 3.7.17; tests via
python -m pytest.