fix(chat): parse opts.visible for workflow prompts and resolve duplicate tool groups in chat UI#2457
Closed
naowalrahman wants to merge 5 commits intoolimorris:mainfrom
Closed
fix(chat): parse opts.visible for workflow prompts and resolve duplicate tool groups in chat UI#2457naowalrahman wants to merge 5 commits intoolimorris:mainfrom
naowalrahman wants to merge 5 commits intoolimorris:mainfrom
Conversation
olimorris
reviewed
Nov 27, 2025
| return | ||
| end | ||
|
|
||
| -- Check if group is already in use to prevent duplicates |
Owner
There was a problem hiding this comment.
We can lose the comments as they don't add any value
olimorris
reviewed
Nov 27, 2025
| val.content = val.content(self.buffer_context) | ||
| end | ||
| chat:add_buf_message(val) | ||
| -- Parse tools and variables from the message content in the following prompts |
Owner
There was a problem hiding this comment.
Again, lose the comments. It's pretty clear what is happening with the code
Owner
|
Thanks for taking the time to put this together! I'm keeping everything locked down until v18.0.0 in a couple of days but will be happy to merge this! |
Contributor
Author
|
Thanks for reviewing! Just removed all the unnecessary comments. |
Contributor
Author
|
Hi, sorry to bug, but any updates on merging this? |
Contributor
|
This PR is stale because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue: Setting
opts = { visible = false }for a workflow prompt is not parsed, meaning the prompt shows up in the chat anyway. Furthermore, mentioning the same tool group twice in a chat session causes the group to be shown twice in the context.Related Issue(s)
Screenshots
Checklist
make allto ensure docs are generated, tests pass and my formatting is appliedCodeCompanion.hasin the init.lua file for my new feature