Skip to content

fix(measurements): Ignore case when parsing probe_asn field#864

Open
nfebe wants to merge 1 commit intoooni:masterfrom
nfebe:fix/318/ignore-case-in-probe-asn-parsing
Open

fix(measurements): Ignore case when parsing probe_asn field#864
nfebe wants to merge 1 commit intoooni:masterfrom
nfebe:fix/318/ignore-case-in-probe-asn-parsing

Conversation

@nfebe
Copy link

@nfebe nfebe commented Jul 23, 2024

Resolves : #318

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@aagbsn
Copy link
Contributor

aagbsn commented Jan 29, 2026

some paths have changed which makes merging this cleanly kind of difficult; here's where your changes would go now:

diff --git a/ooniapi/services/oonimeasurements/src/oonimeasurements/routers/v1/measurements.py b/ooniapi/services/oonimeasurements/src/oonimeasurements/routers/v1/measurements.py
index 06c9381d..fb171a23 100644
--- a/ooniapi/services/oonimeasurements/src/oonimeasurements/routers/v1/measurements.py
+++ b/ooniapi/services/oonimeasurements/src/oonimeasurements/routers/v1/measurements.py
@@ -765,7 +765,7 @@ async def list_measurements(
             probe_asn_list = probe_asn.split(",")
             probe_asn_integer_list = []
             for probe_asn_value in probe_asn_list:
-                if probe_asn_value.startswith("AS"):
+                if probe_asn_value.lower().startswith("as"):
                     probe_asn_value = probe_asn_value[2:]
                 probe_asn_integer_list.append(int(probe_asn_value))
         query_params["probe_asn"] = probe_asn_integer_list

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ignore case when parsing probe_asn field

2 participants