-
Notifications
You must be signed in to change notification settings - Fork 21
cld2labs/ubuntu22.04-deployment-scripts #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
cld2labs/ubuntu22.04-deployment-scripts #49
Conversation
amberjain1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the general structure.
Will wait for validation to complete before reviewing the iac folder.
third_party/Dell/ubuntu-22.04/EI/single-node/user-guide-apisix.md
Outdated
Show resolved
Hide resolved
|
@bagd0003 please add your review comments here |
third_party/Dell/ubuntu-22.04/EI/single-node/user-guide-genai.md
Outdated
Show resolved
Hide resolved
third_party/Dell/ubuntu-22.04/EI/single-node/user-guide-genai.md
Outdated
Show resolved
Hide resolved
third_party/Dell/ubuntu-22.04/EI/single-node/user-guide-genai.md
Outdated
Show resolved
Hide resolved
Co-authored-by: alexsin368 <[email protected]>
third_party/Dell/ubuntu-22.04/EI/single-node/user-guide-genai.md
Outdated
Show resolved
Hide resolved
third_party/Dell/ubuntu-22.04/EI/single-node/user-guide-genai.md
Outdated
Show resolved
Hide resolved
third_party/Dell/ubuntu-22.04/EI/single-node/user-guide-genai.md
Outdated
Show resolved
Hide resolved
| ``` | ||
| **Mount ISO** | ||
| ```bash | ||
| ./mount-iso.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to change all .sh scripts to be executable before I could run them.
chmod 755 ./*.sh
Either add this step or change the permissions of the .sh files before commiting them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated readme to run chmod +x mount.sh before executing the script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bagd0003 Heerak mentioned you had concerns in the way that the ISO is being downloaded from the public ubuntu url, followed by installation via terraform. Please recommend if there is a better way Dell prefers before we upstream this code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this related to ISO mount, already updated the script so that it can pick http and https?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bagd0003 Heerak mentioned you had concerns in the way that the ISO is being downloaded from the public ubuntu URL, followed by installation via terraform. Please recommend if there is a better way Dell prefers before we upstream this code
I've confirmed it is fine to be able to mount the ISO directly from Ubuntu. I'm suggesting to provide an option to enter in an ISO URL in case a user would like to point to their internal location and make sure both HTTP and HTTPS are allowed, which I believe is already taken care of.
As long as you are able to mount the ISO and boot into it via automation, that should do it.
Let me know if you have any other questions.
Vadim
Updated user guide for Intel AI for Enterprise Inference to clarify setup instructions and improve readability.
third_party/Dell/ubuntu-22.04/EI/single-node/user-guide-apisix.md
Outdated
Show resolved
Hide resolved
Updated README.md to include new instructions for mounting ISO and clarify mandatory Terraform variables.
Added instructions for changing file permissions and running the script.
Adding ubuntu deployment scripts under third-party dell folder.