Skip to content

Conversation

@rajeshgangireddy
Copy link
Contributor

@rajeshgangireddy rajeshgangireddy commented Dec 10, 2025

📝 Description

We use dataset (GT) and predictions from model to compare while exporting INT8_ACQ models.
When the metric is image related and not pixel related (which it is by default), we do need to adjust for the cases where gt_mask (from dataset) or anomaly_map (from models) are not present.

Select what type of change your PR is:

  • 🚀 New feature (non-breaking change which adds functionality)
  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔄 Refactor (non-breaking change which refactors the code base)
  • ⚡ Performance improvements
  • 🎨 Style changes (code style/formatting)
  • 🧪 Tests (adding/modifying tests)
  • 📚 Documentation update
  • 📦 Build system changes
  • 🚧 CI/CD configuration
  • 🔧 Chore (general maintenance)
  • 🔒 Security update
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).
  • 🏷️ My PR title follows conventional commit format.

For more information about code review checklists, see the Code Review Checklist.

Copilot AI review requested due to automatic review settings December 10, 2025 16:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes handling of optional fields during INT8_ACQ model export by adding conditional checks for anomaly_map, pred_mask, and gt_mask fields that may not always be present when comparing image-level metrics.

Key Changes:

  • Added conditional existence checks before accessing anomaly_map and pred_mask from model outputs
  • Added conditional check for gt_mask in batch data with proper shape adjustment

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant