-
Notifications
You must be signed in to change notification settings - Fork 66
fix(flagd): do not retry for certain status codes (#756) #799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alexandraoberaigner
wants to merge
9
commits into
open-feature:main
Choose a base branch
from
open-feature-forking:fix/inifinite-loop-error
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix(flagd): do not retry for certain status codes (#756) #799
alexandraoberaigner
wants to merge
9
commits into
open-feature:main
from
open-feature-forking:fix/inifinite-loop-error
+446
−186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Simon Schrottner <[email protected]>
Signed-off-by: Alexandra Oberaigner <[email protected]>
… non-retry error handling (open-feature#756) Signed-off-by: Alexandra Oberaigner <[email protected]>
c0fc81d to
0fbe945
Compare
Signed-off-by: Alexandra Oberaigner <[email protected]>
0fbe945 to
51493a0
Compare
Signed-off-by: Alexandra Oberaigner <[email protected]>
f7bd0f6 to
a2312a3
Compare
…out, disable @forbidden test for rpc Signed-off-by: Alexandra Oberaigner <[email protected]>
a2312a3 to
a25f7be
Compare
Member
|
As we are adding new config options, we should wait for open-feature/flagd-testbed#311 to be merged to ensure property names are in consistent for all the providers based on the docs. |
aepfli
reviewed
Nov 17, 2025
| } | ||
| return reflect.ValueOf(longVal).Convert(fieldType) | ||
| case "StringList": | ||
| arrayVal := strings.Split(value, ",") |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we also need to trim here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
This pull request introduces configurable retry and fatal error handling for the in-process gRPC sync provider in the
flagdproject. The main changes include adding new configuration options for retry backoff timing and fatal status codes, refactoring environment variable parsing, and updating service initialization and error handling logic.Related Issues
Changes
Retry and fatal error configuration (most important):
RetryBackoffMs,RetryBackoffMaxMs,FatalStatusCodes) toProviderConfiguration, with environment variable support and helper functions for parsing integer values from environment variables. [1] [2] [3] [4] [5] [6]Refactoring and code quality:
grpc_config.go, making the code more modular and testable. [1] [2] [3] [4] [5]Error handling improvements:
grpc_config_test.go.