feat(agentos): CAS API-key capability checks, obs group/actor filters…#27
Merged
Merged
Conversation
…, group-claim fallback API-key capability enforcement (ComputerAgent server): - introspection now resolves a key's roleIds -> effective permissions (keys-introspect.ts, via exported resolveEffectivePermissions); the CAS verifier captures them and gates each route (GET -> agents:read, execute/mutate -> agents:run), returning 403 on an under-privileged key (e.g. a viewer key hitting /run). Basic-auth (the agentos loopback) stays full-trust since agentos already enforced RBAC + ownership. Back-compat: a response with no `permissions` field (old AgentOS) is allowed and logged once, so a rolling upgrade doesn't lock keys out. Observability group + actor filters: - new Group + Actor dropdowns beside Agent, built on a reusable, RBAC-scoped FieldValueFilter (AgentFilter is now a thin wrapper). Applied to the Traces explorer (implicit group_id/actor_id eq-filters on the filters[] array) and the Dashboard (group/actor params on /dashboard, both ClickHouse + NRQL). - obs-fields bypasses the otel_field_values materialized view for the non-materialized identity fields (group_id/owner_id/actor_id) so admins get values; group_id/owner_id/actor_id registered as query fields front + back. Group-claim fallback + agent card refresh: - when the OIDC access token carries no `groups` claim, fall back to the Keycloak Admin API (listUserGroups / withGroups) so group-scoped RBAC still works. Best-effort; leaves groups empty on failure. - AgentCard shows model + owner-group chips and a live-status pill; registry grid spacing tweaked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…, group-claim fallback
API-key capability enforcement (ComputerAgent server):
permissionsfield (old AgentOS) is allowed and logged once, so a rolling upgrade doesn't lock keys out.Observability group + actor filters:
Group-claim fallback + agent card refresh:
groupsclaim, fall back to the Keycloak Admin API (listUserGroups / withGroups) so group-scoped RBAC still works. Best-effort; leaves groups empty on failure.Summary
Type of change
Verification
pnpm -r buildcleanpnpm -r typecheckcleanpnpm -r testclean (note any flaky tests in the comment)runConformanceSuite()passes (paste report below)Versioning
pnpm changesetwas run for any change to a published packageNotes for the reviewer