chore: enable golangci formatters exec #960
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogercoll
changed the title
Contributor
Author
|
Enables |
florianl
reviewed
Nov 13, 2025
Makefile
Outdated
| lint: generate vanity-import-check pprof-execs | ||
| $(MAKE) lint -C support/ebpf | ||
| docker run --rm -t -v $$(pwd):/app -w /app golangci/golangci-lint:$(GOLANGCI_LINT_VERSION) sh -c "golangci-lint version && golangci-lint config verify && golangci-lint run --max-issues-per-linter -1 --max-same-issues -1" | ||
| docker run --rm -t -v $$(pwd):/app -w /app golangci/golangci-lint:$(GOLANGCI_LINT_VERSION) sh -c "golangci-lint version && golangci-lint config verify && golangci-lint run --max-issues-per-linter -1 --max-same-issues -1 && golangci-lint fmt" |
Contributor
There was a problem hiding this comment.
As docker in docker is always a painful experience, should we just use golangci-lint as part of go tool?
# One time setup:
go mod init -modfile=tools.mod go.opentelemetry.io/ebpf-profiler
go get -tool -modfile=tools.mod github.com/golangci/golangci-lint/v2/cmd/[email protected]
# Run golangci-lint
make generate
make generate pprof-execs
go tool -modfile=tools.mod golangci-lint run && go tool -modfile=tools.mod golangci-lint fmt
This would also speed up CI, as pulling docker images is no longer required. With the dedicated tools.mod file, tooling like that is also separated from the rest of the project.
Contributor
Author
There was a problem hiding this comment.
Yes, I am in favor of using Go's tools chain tools. Changed in 28d1206
florianl
reviewed
Nov 13, 2025
Co-authored-by: Florian Lehner <[email protected]>
florianl
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Golangci formatters were not running. This PR adds a command to format the code using golangci and making the CI fail if not formatted accordingly.