-
Notifications
You must be signed in to change notification settings - Fork 706
otelconf: Increased test coverage for Prometheus-related code #7440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7440 +/- ##
=====================================
Coverage 81.8% 81.8%
=====================================
Files 194 194
Lines 13362 13362
=====================================
+ Hits 10931 10936 +5
+ Misses 2033 2029 -4
+ Partials 398 397 -1 🚀 New features to boost your workflow:
|
|
@sonalgaud12, are you able to address the comments? |
Co-authored-by: Tyler Yahn <[email protected]>
|
@sonalgaud12, are you able to address @XSAM's comments? |
|
Need approval from @codeboten @MrAlias |
codeboten
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sonalgaud12
This PR fixes #6821
Added test for prometheusReader function for both v0.3.0 & v0.2.0
Locally tested