Skip to content

Conversation

@sonalgaud12
Copy link
Contributor

This PR fixes #6821

  • Added test for prometheusReader function for both v0.3.0 & v0.2.0

  • Locally tested

@sonalgaud12 sonalgaud12 requested review from a team and pellared as code owners June 7, 2025 15:16
@codecov
Copy link

codecov bot commented Jun 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.8%. Comparing base (a2c5420) to head (7c0fe97).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #7440   +/-   ##
=====================================
  Coverage   81.8%   81.8%           
=====================================
  Files        194     194           
  Lines      13362   13362           
=====================================
+ Hits       10931   10936    +5     
+ Misses      2033    2029    -4     
+ Partials     398     397    -1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dmathieu dmathieu added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Jun 10, 2025
@sonalgaud12 sonalgaud12 requested a review from pellared June 11, 2025 04:54
@github-actions github-actions bot requested a review from codeboten July 7, 2025 07:14
@pellared
Copy link
Member

@sonalgaud12, are you able to address the comments?

@pellared pellared requested a review from MrAlias August 4, 2025 12:54
Co-authored-by: Tyler Yahn <[email protected]>
@sonalgaud12 sonalgaud12 requested a review from MrAlias August 6, 2025 15:26
@pellared
Copy link
Member

@sonalgaud12, are you able to address @XSAM's comments?

@sonalgaud12
Copy link
Contributor Author

@pellared @XSAM I have made all the changes. Can you guys review it once and let me know if anything else is required?

@sonalgaud12
Copy link
Contributor Author

Need approval from @codeboten @MrAlias

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sonalgaud12

@dmathieu dmathieu merged commit 7ff03d6 into open-telemetry:main Nov 10, 2025
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG

Projects

None yet

Development

Successfully merging this pull request may close these issues.

otelconf: Increase test coverage for Prometheus-related code

6 participants