Skip to content

Conversation

@codeboten
Copy link
Contributor

@codeboten codeboten commented Oct 21, 2025

There is no functional change here, only moving the code as the 1.0.0 version will be able to reuse this code in the common location.

Part of #8026

There is no functional change here, only moving the code as the 1.0.0 version will be able to reuse this code in the common location.

Signed-off-by: alex boten <[email protected]>
@codeboten codeboten requested review from a team and pellared as code owners October 21, 2025 19:49
@codeboten
Copy link
Contributor Author

Since there's no functional change i didn't think this needed a changelog

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 87.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.6%. Comparing base (e0f043f) to head (99b7d05).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
otelconf/internal/tls/config.go 83.3% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #8050     +/-   ##
=======================================
+ Coverage   78.5%   79.6%   +1.0%     
=======================================
  Files        185     186      +1     
  Lines      14760   11865   -2895     
=======================================
- Hits       11598    9452   -2146     
+ Misses      2808    2059    -749     
  Partials     354     354             
Files with missing lines Coverage Δ
otelconf/v0.3.0/config.go 92.8% <ø> (+2.9%) ⬆️
otelconf/v0.3.0/log.go 97.6% <100.0%> (+0.1%) ⬆️
otelconf/v0.3.0/metric.go 89.7% <100.0%> (+0.3%) ⬆️
otelconf/v0.3.0/trace.go 99.4% <100.0%> (-0.2%) ⬇️
otelconf/internal/tls/config.go 83.3% <83.3%> (ø)

... and 176 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: alex boten <[email protected]>
Signed-off-by: alex boten <[email protected]>
Signed-off-by: alex boten <[email protected]>
@dmathieu dmathieu added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Oct 22, 2025
@MrAlias MrAlias merged commit 99b9e2a into open-telemetry:main Oct 23, 2025
28 checks passed
@codeboten codeboten deleted the codeboten/refactor-create-tls branch October 23, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants