-
Notifications
You must be signed in to change notification settings - Fork 706
otelhttp: deprecate WithPublicEndpoint in favor of WithPublicEndpointFn (#8133) #8152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dmathieu
merged 7 commits into
open-telemetry:main
from
n2p5:otelhttp/deprecate-withpublicendpoint
Nov 13, 2025
Merged
otelhttp: deprecate WithPublicEndpoint in favor of WithPublicEndpointFn (#8133) #8152
dmathieu
merged 7 commits into
open-telemetry:main
from
n2p5:otelhttp/deprecate-withpublicendpoint
Nov 13, 2025
+9
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…Fn (open-telemetry#8133) WithPublicEndpoint() now delegates to WithPublicEndpointFn to reduce code duplication and maintenance burden. The PublicEndpoint bool field has been removed from the config and middleware structs in favor of using only PublicEndpointFn. This simplifies the implementation to a single code path while maintaining full backward compatibility.
bc4cc69 to
ee46d1a
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8152 +/- ##
=======================================
- Coverage 81.8% 81.8% -0.1%
=======================================
Files 194 194
Lines 13380 13377 -3
=======================================
- Hits 10954 10951 -3
Misses 2029 2029
Partials 397 397
🚀 New features to boost your workflow:
|
dmathieu
approved these changes
Nov 10, 2025
flc1125
approved these changes
Nov 10, 2025
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses Issue: #8133
WithPublicEndpointnow delegates toWithPublicEndpointFnto reduce code duplication and maintenance burden. The PublicEndpoint bool field has been removed from the config and middleware structs in favor of using only PublicEndpointFn.This simplifies the implementation to a single code path while maintaining full backward compatibility.