Skip to content

Conversation

@CodeBlanch
Copy link
Member

Changes

  • Switch selection helper methods from Result<Option<ResolvedValueMut<'b, 'c>>, ExpressionError> to just Option<ResolvedValueMut<'b, 'c>> because they weren't returning errors

@CodeBlanch CodeBlanch requested a review from a team as a code owner December 8, 2025 18:14
@github-actions github-actions bot added rust Pull requests that update Rust code query-engine Query Engine / Transform related tasks query-engine-recordset Reference query engine implementation processing over a set of records labels Dec 8, 2025
@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

❌ Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.52%. Comparing base (99113cf) to head (2604793).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1546      +/-   ##
==========================================
- Coverage   83.55%   83.52%   -0.04%     
==========================================
  Files         428      428              
  Lines      119720   119716       -4     
==========================================
- Hits       100038    99995      -43     
- Misses      19148    19187      +39     
  Partials      534      534              
Components Coverage Δ
otap-dataflow 84.69% <ø> (-0.07%) ⬇️
query_abstraction 80.61% <ø> (ø)
query_engine 90.31% <70.58%> (+<0.01%) ⬆️
syslog_cef_receivers ∅ <ø> (∅)
otel-arrow-go 53.50% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@drewrelmas drewrelmas added this pull request to the merge queue Dec 8, 2025
Merged via the queue into open-telemetry:main with commit b6bc9e7 Dec 8, 2025
33 of 34 checks passed
@CodeBlanch CodeBlanch deleted the query-engine-recordset-mutable-value-read-cleanup branch December 8, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

query-engine Query Engine / Transform related tasks query-engine-recordset Reference query engine implementation processing over a set of records rust Pull requests that update Rust code

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants