-
Notifications
You must be signed in to change notification settings - Fork 64
InternalMetrics- conditionally start dispatch thread if there are any readers #1555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
albertlockett
merged 6 commits into
open-telemetry:main
from
cijothomas:cijothomas/conditional-metrics
Dec 9, 2025
Merged
InternalMetrics- conditionally start dispatch thread if there are any readers #1555
albertlockett
merged 6 commits into
open-telemetry:main
from
cijothomas:cijothomas/conditional-metrics
Dec 9, 2025
+20
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1555 +/- ##
=======================================
Coverage 83.76% 83.76%
=======================================
Files 433 433
Lines 122633 122639 +6
=======================================
+ Hits 102719 102732 +13
+ Misses 19380 19373 -7
Partials 534 534
🚀 New features to boost your workflow:
|
andborja
reviewed
Dec 9, 2025
andborja
reviewed
Dec 9, 2025
andborja
reviewed
Dec 9, 2025
andborja
reviewed
Dec 9, 2025
andborja
approved these changes
Dec 9, 2025
albertlockett
approved these changes
Dec 9, 2025
Merged
via the queue into
open-telemetry:main
with commit Dec 9, 2025
76a861d
32 of 33 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate to #1552Since perf tests don't create service/telemetry, this will also unblock perf tests.
Simple optimization- avoid the thread creation if there are no readers.