Skip to content

Conversation

@cijothomas
Copy link
Member

@cijothomas cijothomas commented Dec 9, 2025

Alternate to #1552
Since perf tests don't create service/telemetry, this will also unblock perf tests.

Simple optimization- avoid the thread creation if there are no readers.

@cijothomas cijothomas requested a review from a team as a code owner December 9, 2025 00:46
@github-actions github-actions bot added the rust Pull requests that update Rust code label Dec 9, 2025
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.76%. Comparing base (01fa772) to head (9aa8318).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1555   +/-   ##
=======================================
  Coverage   83.76%   83.76%           
=======================================
  Files         433      433           
  Lines      122633   122639    +6     
=======================================
+ Hits       102719   102732   +13     
+ Misses      19380    19373    -7     
  Partials      534      534           
Components Coverage Δ
otap-dataflow 85.06% <0.00%> (+0.01%) ⬆️
query_abstraction 80.61% <ø> (ø)
query_engine 90.31% <ø> (ø)
syslog_cef_receivers ∅ <ø> (∅)
otel-arrow-go 53.50% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cijothomas cijothomas changed the title InternalMetrics- conditionally start reported if there are any readers InternalMetrics- conditionally start dispatch thread if there are any readers Dec 9, 2025
@albertlockett albertlockett added this pull request to the merge queue Dec 9, 2025
Merged via the queue into open-telemetry:main with commit 76a861d Dec 9, 2025
32 of 33 checks passed
@cijothomas cijothomas deleted the cijothomas/conditional-metrics branch December 9, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rust Pull requests that update Rust code

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants