Skip to content

refactor: remove advanced filters from CustomApiExplorerPage and CustomCatalogPage#444

Merged
kaviththiranga merged 1 commit intoopenchoreo:mainfrom
stefinie123:deploy-fix
Mar 19, 2026
Merged

refactor: remove advanced filters from CustomApiExplorerPage and CustomCatalogPage#444
kaviththiranga merged 1 commit intoopenchoreo:mainfrom
stefinie123:deploy-fix

Conversation

@stefinie123
Copy link
Contributor

@stefinie123 stefinie123 commented Mar 19, 2026

Purpose

Remove advanced filters from CustomApiExplorerPage and CustomCatalogPage

image image

Summary by CodeRabbit

  • UI Improvements
    • Removed the Advanced Filters feature from the catalog, including the toggle button and associated filtering options for lifecycle, tags, and processing status across both desktop and mobile views
    • Streamlined the overall filtering experience to focus on core search capabilities, delivering a significantly cleaner and more intuitive user interface

…omCatalogPage

- Eliminated advanced filters functionality from both CustomApiExplorerPage and CustomCatalogPage components, including associated state management and UI elements.
- Updated styles to remove unused classes related to advanced filters.

Signed-off-by: Stefinie Fernando <minolispencer@gmail.com>
@coderabbitai
Copy link

coderabbitai bot commented Mar 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e0c9fc31-6809-4c71-835e-77fcfad37823

📥 Commits

Reviewing files that changed from the base of the PR and between 806b2bb and 9e69c32.

📒 Files selected for processing (3)
  • packages/app/src/components/catalog/CustomApiExplorerPage.tsx
  • packages/app/src/components/catalog/CustomCatalogPage.tsx
  • packages/app/src/components/catalog/styles.ts
💤 Files with no reviewable changes (1)
  • packages/app/src/components/catalog/styles.ts

📝 Walkthrough

Walkthrough

This pull request removes advanced filtering UI components and their associated styles from two catalog pages (CustomApiExplorerPage and CustomCatalogPage). The changes eliminate filter pickers, toggle controls, state management for advanced filters, and corresponding CSS classes from the codebase.

Changes

Cohort / File(s) Summary
Advanced Filter UI Components
packages/app/src/components/catalog/CustomApiExplorerPage.tsx, packages/app/src/components/catalog/CustomCatalogPage.tsx
Removed advanced filters section including toggle state (advancedFiltersOpen), toggle button with expand icon, and conditional rendering of EntityTagPicker, EntityLifecyclePicker, and EntityProcessingStatusPicker. Updated imports to remove these picker components. Mobile filter drawer simplified to retain only StarredFilter (and ChoreoEntityKindPicker in CustomCatalogPage).
Advanced Filter Styles
packages/app/src/components/catalog/styles.ts
Removed five style class definitions: advancedFiltersGridItem, advancedFiltersToggle, advancedFiltersIcon, advancedFiltersExpanded, and hideWhenEmpty. These governed flex layout, hover effects, icon rotation animations, and conditional visibility.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • PR #265: Introduced the advanced filters UI and picker components that are now being removed in this PR.
  • PR #388: Also modifies catalog API listing page filter UI by removing specific picker components (namespace picker).

Suggested reviewers

  • sameerajayasoma
  • jhivandb
  • kaviththiranga

Poem

🐰 Filters fall like autumn leaves,
Advanced UI now takes its leave,
Cleaner code, simpler sight,
The catalog gleams, streamlined and bright!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only includes Purpose section with minimal detail and screenshots, missing most required sections like Goals, Approach, User stories, Release note, Documentation, and others. Expand the description to include Goals, Approach, User stories, Release note, Documentation, and other required template sections to provide comprehensive context for reviewers.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: removing advanced filters from two specific components.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can approve the review once all CodeRabbit's comments are resolved.

Enable the reviews.request_changes_workflow setting to automatically approve the review once all CodeRabbit's comments are resolved.

@kaviththiranga kaviththiranga merged commit f22e4e7 into openchoreo:main Mar 19, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants