Update pvsite_forecast.py#340
Open
Joy-chakraborty-23 wants to merge 2 commits intoopenclimatefix:mainfrom
Open
Update pvsite_forecast.py#340Joy-chakraborty-23 wants to merge 2 commits intoopenclimatefix:mainfrom
Joy-chakraborty-23 wants to merge 2 commits intoopenclimatefix:mainfrom
Conversation
This PR updates all occurrences of "T" in pvsite_forecast.py so that: Sidebar resample options are now ["15min", "30min"] instead of ["15T", "30T"]. User caption prompts the user to resample to "15min" instead of "15T". All calls to .resample(resample) and any literal frequency strings use "min" rather than the deprecated "T".
This PR updates all occurrences of "T" in pvsite_forecast.py so that: Sidebar resample options are now ["15min", "30min"] instead of ["15T", "30T"]. User caption prompts the user to resample to "15min" instead of "15T". All calls to .resample(resample) and any literal frequency strings use "min" rather than the deprecated "T"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates all occurrences of "T" in pvsite_forecast.py so that:
Sidebar resample options are now ["15min", "30min"] instead of ["15T", "30T"].
User caption prompts the user to resample to "15min" instead of "15T".
All calls to .resample(resample) and any literal frequency strings use "min" rather than the deprecated "T".
Pull Request
Description
Please delete the italicised instruction text!
Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration
If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?
Checklist: