fix docker compose to setup dashboard#387
Open
prashantpandeygit wants to merge 1 commit intoopenclimatefix:mainfrom
Open
fix docker compose to setup dashboard#387prashantpandeygit wants to merge 1 commit intoopenclimatefix:mainfrom
prashantpandeygit wants to merge 1 commit intoopenclimatefix:mainfrom
Conversation
Contributor
Author
|
@peterdudfield can you have a look at this too? thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
the docker build was broken, the docker-compose up --build failed and threw the error attached

this happens as the docker-compose.yml file overrides the CMD command that is already at the bottom of the DockerFile which is responsible for the allocation of port and streamlit launch command, the change made now help the image to build using the docker-compose.yml and launches the port and streamlit using DockerFile causing no issues
To Reproduce error
How Has This Been Tested?
rebuilt the image as per the readme, and the streamlit app is ready on the port
If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?
Checklist: