Skip to content

Comments

Numpy conversion consolidation function#396

Open
felix-e-h-p wants to merge 2 commits intomainfrom
numpy-conversion-consolidation
Open

Numpy conversion consolidation function#396
felix-e-h-p wants to merge 2 commits intomainfrom
numpy-conversion-consolidation

Conversation

@felix-e-h-p
Copy link
Contributor

@felix-e-h-p felix-e-h-p commented Feb 17, 2026 •
edited
Loading

Consolidate numpy sample conversion into a single function - as referenced in #368 (think also related to #255)

Implemented single convert_to_numpy_sample(sample, t0) in convert.py:

  • Accepts dict of xarray objects that already exist in PVNet Dataset classes.
  • Modalities optional.
  • The {X}SampleKey classes all removed.

All related tests updated to use string keys instead of now old class attributes.

@felix-e-h-p felix-e-h-p requested a review from dfulu February 17, 2026 16:22
@felix-e-h-p felix-e-h-p marked this pull request as ready for review February 17, 2026 16:30
@dfulu dfulu mentioned this pull request Feb 18, 2026
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dfulu dfulu Awaiting requested review from dfulu

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@felix-e-h-p