Issues/1478 integrate tiptap for writing emails #1831
+1,117
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR integrates TipTap as a rich text editor for composing emails, replacing the previous plain textarea implementation with a full-featured formatting toolbar and editor.
Changes:
- Added TipTap dependencies and configured editor with formatting extensions (bold, italic, underline, lists, links, blockquote)
- Implemented a new MailBodyEditor component with formatting toolbar and link modal
- Updated MailComposeForm and MailWidget to support the new editor with toggle for formatting toolbar
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/web-app-mail/src/views/MailCompose.vue | New email compose view with basic form structure and account loading |
| packages/web-app-mail/src/components/MailWidget.vue | Updated widget layout to accommodate TipTap editor with formatting toolbar toggle |
| packages/web-app-mail/src/components/MailSearch.vue | Contains placeholder/note text instead of actual implementation |
| packages/web-app-mail/src/components/MailComposeFormattingToolbar.vue | New toolbar component with formatting buttons for the TipTap editor |
| packages/web-app-mail/src/components/MailComposeForm.vue | Updated to use MailBodyEditor instead of textarea |
| packages/web-app-mail/src/components/MailBodyEditor.vue | New TipTap-based rich text editor with modal for link insertion |
| packages/web-app-mail/package.json | Added TipTap dependencies and DOMPurify |
| packages/design-system/src/components/OcModal/OcModal.vue | Renamed modal slot from 'headerActions' to 'modal-slot-header-actions' |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JammingBen
reviewed
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate TipTap for writing emails #1478